Hi Marco,
The test file "tests/gsa/ls2003.mod" does not run on my box, because it says that I must download an ANOVA toolbox.
I think we should not include tests that depend on software outside Dynare.
Do you think you can adapt the test so that it runs without external downloads?
Thanks,
Yes, I can comment out the dynare calls that trigger the external toolbox. Alternatively, in place of sending an error in the routine, I simply give a warning + a return. In this way, the execution will go to the next instruction.
The latest option may be best? I will simply replace the error instruction line in dynare_sensitivity with a warning line, are you ok?
best Marco
On 10/7/2011 2:50 PM, Sébastien Villemot wrote:
Hi Marco,
The test file "tests/gsa/ls2003.mod" does not run on my box, because it says that I must download an ANOVA toolbox.
I think we should not include tests that depend on software outside Dynare.
Do you think you can adapt the test so that it runs without external downloads?
Thanks,
Marco Ratto marco.ratto@jrc.ec.europa.eu writes:
Yes, I can comment out the dynare calls that trigger the external toolbox. Alternatively, in place of sending an error in the routine, I simply give a warning + a return. In this way, the execution will go to the next instruction.
The latest option may be best? I will simply replace the error instruction line in dynare_sensitivity with a warning line, are you ok?
I don't really like the idea of just printing a warning and returning. The user may miss it. An error is probably more appropriate if Dynare cannot run what the user has asked for. For me the current behavior is ok.
My concern is more about the test file: currently the testsuite fails on the GSA test because on my machine I don't have the external toolbox. So my request is more about changing the testfile, so that it does not require that toolbox. Or, alternatively, remove that test file (but then replace it by another one in order to have at least one GSA test in the testsuite).
Best,
-
Marco Ratto -
Sébastien Villemot