Re: [DynareDev] [Dynare Git] Dynare branch, master, updated. fe98a0875dae6edb78973aa759a3fe1bc2ad4ccc
Stéphane: why did you make the following change? According to the DynareOctave wiki page, the EPS extension is not automatically added by Octave. Did you test it under Octave?
commit 69efc894c6dc9ac1250bd7450bd57443f088c242 Author: Stéphane Adjemian (Charybdis) stephane.adjemian@univ-lemans.fr Date: Fri Aug 24 14:56:44 2012 +0200
Fixed bug. Removed extension declaration for Encapsulated PostScript graphics file format.diff --git a/matlab/dyn_saveas.m b/matlab/dyn_saveas.m index 2a53cb7..7585568 100644 --- a/matlab/dyn_saveas.m +++ b/matlab/dyn_saveas.m @@ -31,7 +31,7 @@ function dyn_saveas(h,fname,DynareOptions) % along with Dynare. If not, see http://www.gnu.org/licenses/.
if (strcmp('eps',DynareOptions.graph_format))
- eval(['print -depsc2 ' fname '.eps']);
- eval(['print -depsc2 ' fname]);% '.eps']);
end if (strcmp('pdf',DynareOptions.graph_format)) eval(['print -dpdf ' fname]);
Summary of changes: matlab/dyn_saveas.m | 2 +- matlab/graph_decomp.m | 16 +++++++++------- matlab/shock_decomposition.m | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-)
hooks/post-receive
Sébastien, I did not test the change under octave... With the eps extension the code crashes under matlab 2012a. I suppose we should add a test for octave... I was not aware of this issue with Octave (I should read the wiki ;-). Shouldn't we also test for octave when DynareOptions.graph_format is set to 'pdf' ?
Best, Stéphane.
On 28/08/2012 23:48, Sébastien Villemot wrote:
Stéphane: why did you make the following change? According to the DynareOctave wiki page, the EPS extension is not automatically added by Octave. Did you test it under Octave?
commit 69efc894c6dc9ac1250bd7450bd57443f088c242 Author: Stéphane Adjemian (Charybdis) stephane.adjemian@univ-lemans.fr Date: Fri Aug 24 14:56:44 2012 +0200
Fixed bug. Removed extension declaration for Encapsulated PostScript graphics file format.diff --git a/matlab/dyn_saveas.m b/matlab/dyn_saveas.m index 2a53cb7..7585568 100644 --- a/matlab/dyn_saveas.m +++ b/matlab/dyn_saveas.m @@ -31,7 +31,7 @@ function dyn_saveas(h,fname,DynareOptions) % along with Dynare. If not, see http://www.gnu.org/licenses/.
if (strcmp('eps',DynareOptions.graph_format))
- eval(['print -depsc2 ' fname '.eps']);
- eval(['print -depsc2 ' fname]);% '.eps']);
end if (strcmp('pdf',DynareOptions.graph_format)) eval(['print -dpdf ' fname]);
Summary of changes: matlab/dyn_saveas.m | 2 +- matlab/graph_decomp.m | 16 +++++++++------- matlab/shock_decomposition.m | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-)
hooks/post-receive
Dev mailing list Dev@dynare.org https://www.dynare.org/cgi-bin/mailman/listinfo/dev
Stéphane Adjemian stepan@dynare.org writes:
Sébastien, I did not test the change under octave... With the eps extension the code crashes under matlab 2012a.
This must be a change in recent versions of MATLAB, because this used to work.
I suppose we should add a test for octave...
Yes indeed.
Shouldn't we also test for octave when DynareOptions.graph_format is set to 'pdf' ?
We should probably omit the creation of the PDF and emit a warning saying that Octave cannot create PDFs.
Thanks,
Ok. I am not in the master branch right now but I will fix this by the end of the day.
Best, Stéphane.
On 29/08/2012 10:47, Sébastien Villemot wrote:
Stéphane Adjemian stepan@dynare.org writes:
Sébastien, I did not test the change under octave... With the eps extension the code crashes under matlab 2012a.
This must be a change in recent versions of MATLAB, because this used to work.
I suppose we should add a test for octave...
Yes indeed.
Shouldn't we also test for octave when DynareOptions.graph_format is set to 'pdf' ?
We should probably omit the creation of the PDF and emit a warning saying that Octave cannot create PDFs.
Thanks,
Dev mailing list Dev@dynare.org https://www.dynare.org/cgi-bin/mailman/listinfo/dev
-
Stéphane Adjemian -
Sébastien Villemot