Hi Houtan and Stéphane,
how are unit test dependencies dealt with? Currently, we do not run
estimation/fs2000.mod
but several tests depend on it like
optimizers/fs2000_102.m.trs: estimation/fs2000.m.trs
Is the fs2000.mod automatically run? Or do we need to add the fs2000.mod again?
--
Johannes Pfeifer
Friesenwall 104
50672 Köln
Tel.: +49-221-29873852
Mobil.: +49-170-6936820
Germany
Hi,
Re estimation/fs2000.mod, this was introduced in ad8586f87c00daf32a59ea03ba1840796df4a9f6 and seems like a typo to me as estimation/fs2000_mf.mod is not in the list of mod files that's called.
Re optimizers/fs2000_102.mod, this dependency was introduced in 1614805c177d85ea96cab6236ead31b8cfd1484d and you're right that this makes sense only if fs2000.mod is called, but that file is not in this directory. It was split up into the fs2000_*.mod files.
Stephane made both of these changes, so he will fix them when he has a moment.
Best, Houtan
On 08/06/2015 08:58 AM, Johannes Pfeifer wrote:
Hi Houtan and Stéphane,
how are unit test dependencies dealt with? Currently, we do not run
estimation/fs2000.mod
but several tests depend on it like
optimizers/fs2000_102.m.trs: estimation/fs2000.m.trs
Is the fs2000.mod automatically run? Or do we need to add the fs2000.mod again?
--
Johannes Pfeifer
Friesenwall 104
50672 Köln
Tel.: +49-221-29873852
Mobil.: +49-170-6936820
Germany
Dev mailing list Dev@dynare.org https://www.dynare.org/cgi-bin/mailman/listinfo/dev
I actually checked, an make calls all required dependencies if they were not called before. That's why there are no problems. But you are right that explicitly calling the tests makes more sense.
-----Ursprüngliche Nachricht----- Von: Dev [mailto:dev-bounces@dynare.org] Im Auftrag von Houtan Bastani Gesendet: Donnerstag, 6. August 2015 14:20 An: List for Dynare developers Betreff: Re: [DynareDev] Unit test dependencies
Hi,
Re estimation/fs2000.mod, this was introduced in ad8586f87c00daf32a59ea03ba1840796df4a9f6 and seems like a typo to me as estimation/fs2000_mf.mod is not in the list of mod files that's called.
Re optimizers/fs2000_102.mod, this dependency was introduced in 1614805c177d85ea96cab6236ead31b8cfd1484d and you're right that this makes sense only if fs2000.mod is called, but that file is not in this directory. It was split up into the fs2000_*.mod files.
Stephane made both of these changes, so he will fix them when he has a moment.
Best, Houtan
On 08/06/2015 08:58 AM, Johannes Pfeifer wrote:
Hi Houtan and Stéphane,
how are unit test dependencies dealt with? Currently, we do not run
estimation/fs2000.mod
but several tests depend on it like
optimizers/fs2000_102.m.trs: estimation/fs2000.m.trs
Is the fs2000.mod automatically run? Or do we need to add the fs2000.mod again?
--
Johannes Pfeifer
Friesenwall 104
50672 Köln
Tel.: +49-221-29873852
Mobil.: +49-170-6936820
Germany
Dev mailing list Dev@dynare.org https://www.dynare.org/cgi-bin/mailman/listinfo/dev
_______________________________________________ Dev mailing list Dev@dynare.org https://www.dynare.org/cgi-bin/mailman/listinfo/dev