Hi Houtan,
Yes. I changed the order of the outputs from the kronecker mex files because I don't want to have the error code as the first output argument. This complicates considerably the calls to these routines (we have in some situations to create a lot of temporary variables) and makes the code more difficult to read. Obviously I had to remove the test on the number of output arguments... I tested all these changes and I didn't see any problems.
Yes. I introduced inconsistencies in the treatment of the error codes. I think we should change all the mex files... But we have time to discuss this. In my view, the reversed ordering of the outputs is preferable if we have to call a large number of times the mex routines.
Best, Stéphane.
Houtan Bastani houtanb@gmail.com writes:
Hi Stephane,
In commit 560800bcc53b389cc6130bfcc131ff4a5e4bfbc0, you change the order of the error output. What was the reason for this? It makes these mex files inconsistent with all of the other ones.
Also, why did you remove the check on the size of nlhs in the mex files. This should be there to ensure that nlhs contains an error code as, if nlhs == 0, no error code will be produced (see dynmex.h). Also, in removing the check on nlhs but still assigning to plhs, I think the mex file will crash if there are not enough lhs return values.
Best, Houtan
On 5 Sep 2011, at 12:54 PM, Stephane Adjemian wrote:
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Dynare".
The branch, master has been updated via 1e04330fe897874f41e930b999b6d0ac58c66bca (commit) via b923ccd4e8fc3a17b42b112c339d2e57e29deba9 (commit) via ada3eec81bc6be4bad0a42a13e3b270389a044f1 (commit) via a792f3f0b36a8a99a010420140fb707c9def94f6 (commit) via c0faa2ccb8c2dedbfd44908ac7eef461b00d7f0d (commit) via f3652af93858432e0a2fc1f3c351a5cc715b6baa (commit) via a73022403128a9496497eaa8381a8ba50a9d1ddd (commit) via 560800bcc53b389cc6130bfcc131ff4a5e4bfbc0 (commit) via 9b9fb7df3a71594f15b6cfce6c0307c7515eaac4 (commit) via 3545be02268275ccbe5253ca5308321948641c17 (commit) via a2b1ce977f92498b7adf411ae5817be5ec149aa3 (commit) via d0fe3c8ae449634c476e0b9aa6101281d6898fea (commit) via 2c8b71ae05cb4cbca821286650607e31bb3c044d (commit) via ff98f65cf6dda854a645ca90471d1ad4e6aa330d (commit) via 8982d495399b95acc62ea726a6900d8104c33b14 (commit) via 31c6f1c998a16e1b313b7a4d3996f2524482664c (commit) via 237744fe7e05ff3b7ad3358550e4d3883a0b3cd0 (commit) via 467c60c51e1eec01a12cb2f13ccd9da7a4df1305 (commit) via 85e0ca379a11e01b92eeb97100b651cdfb611d77 (commit) via e905ff77c09a0e91da6b336b811279c7c16349d5 (commit) via fe59061e91419ec8b16af481d038f6f8a976ef04 (commit) via 5efcf7527d940fae12a385a7577f98048e4cd32b (commit) via b9c35234e1118ae85eacdf96f605fd41412144f7 (commit) via 948594c35f386d4d68231616cbaa0fb78d4d5102 (commit) via 4323653f08af533034faa176e3aca3de168a52f2 (commit) via 8c49e99ee8c9044520adde5e7c95f448578969b7 (commit) via 316e16edc2838d434df43bafbc697015377bb154 (commit) via 8c4e24769b4bb271bbb060c29191b107e5293597 (commit) via 9b00852e255c30ddca30ffcea63e37c674dfc230 (commit) via 0c61ddc63a9d12a5e6fedfdabf170c0038a1e918 (commit) from 8345de43b0489634aab6f0eec6ce0c539a93b0ba (commit)
Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.